> On Feb. 9, 2016, 9:40 a.m., Lenni Kuff wrote: > > sentry-provider/sentry-provider-db/src/main/resources/sentry_generic_policy_service.thrift, > > line 225 > > <https://reviews.apache.org/r/43234/diff/2/?file=1237849#file1237849line225> > > > > comment. > > > > Also, why do we need to pass groups in the req, shouldn't the service > > resolve this? Do we need to use a set, or can a list work?
The groups in the req is for admin to request info for a specific groups. This aligns with the api implementation in v1. Added comments. Using a set can avoid duplicate here. - Hao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43234/#review118377 ----------------------------------------------------------- On Feb. 8, 2016, 11:23 p.m., Hao Hao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43234/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2016, 11:23 p.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Change-Id: I679341bfd24a3653060a024799c09c9ab907bc49 > > SENTRY-993: list_sentry_privileges_by_authorizable() gone in API v2. > > Change-Id: If070e96f9c6a66f84a25f40a2bbbdcbc2de28e36 > > > Added list_sentry_privileges_by_authorizable() for generic model thrift API. > The interface will return a <Authorizables, <Role, Set<Privileges>>> mapping. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyService.java > b42159852e1a3cc14f34b106c9c60f8436d6fdd7 > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TListSentryPrivilegesByAuthRequest.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TListSentryPrivilegesByAuthResponse.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TSentryPrivilegeMap.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > e1c15fa5304b553f69ef4d7e5053d587efb92ae5 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java > c3b0be8694c746cb09797425f98578b8faef8b4a > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java > f6d73e728f04cbb2a54595dc4d7d2b78fcd02838 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessor.java > 78d38473f938b1aa2b357dd858b00f833147ee5d > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClientDefaultImpl.java > ce5751389670e5f2de07c1664346d1c5c26a3445 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 521d945222c240552ecde7a66b35bc5baef84a41 > > sentry-provider/sentry-provider-db/src/main/resources/sentry_generic_policy_service.thrift > 91ff672ec943003460e38892fd536444596b5795 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestPrivilegeOperatePersistence.java > 189eabb2724e4187a39b1d1341fd231b1ac928b7 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericPolicyProcessor.java > b86c6b2c1350924683c3d3ed293502d211bcde2d > > Diff: https://reviews.apache.org/r/43234/diff/ > > > Testing > ------- > > Tested in TestSentryGenericPolicyProcessor and > TestPrivilegeOperatePersistence. > > > Thanks, > > Hao Hao > >
