brainy commented on code in PR #7:
URL: https://github.com/apache/serf/pull/7#discussion_r2155028668
##########
test/certs/create_certs.py:
##########
@@ -73,18 +73,18 @@ def create_crl(revokedcert, cakey, cacert, crlfile,
next_crl_days=VALID_DAYS):
now = datetime.utcnow()
now_str = now.strftime('%Y%m%d%H%M%SZ')
- revoked.set_serial(serial_number)
- revoked.set_reason('unspecified')
- revoked.set_rev_date(now_str) # revoked as of now
+ revoked.set_serial(serial_number.encode('ascii'))
+ revoked.set_reason(b'unspecified')
+ revoked.set_rev_date(now_str.encode('ascii')) # revoked as of now
crl.add_revoked(revoked)
try:
- exported = crl.export(cacert, cakey, days=next_crl_days, digest=b"md5")
+ exported = crl.export(cacert, cakey, days=next_crl_days,
digest=b"sha256")
except TypeError:
Review Comment:
(By the way, that script still uses pyOpenSSL ... highly recommended to use
python-cryptography instead. But that's not the topic here.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@serf.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
