chemodax commented on code in PR #7:
URL: https://github.com/apache/serf/pull/7#discussion_r2160116439
##########
serf_bucket_types.h:
##########
@@ -583,6 +583,8 @@ serf_bucket_t *serf_bucket_limit_create(
#define SERF_SSL_OCSP_RESPONDER_ERROR 0x0200
#define SERF_SSL_OCSP_RESPONDER_UNKNOWN_FAILURE 0x0400
+#define SERF_SSL_SIGNATURE_FAILURE 0x0800
+
Review Comment:
Indentation -- values should be aligned.
##########
buckets/ssl_buckets.c:
##########
@@ -890,6 +890,10 @@ validate_server_certificate(int cert_valid, X509_STORE_CTX
*store_ctx)
case X509_V_ERR_UNABLE_TO_GET_CRL:
failures |= SERF_SSL_CERT_UNABLE_TO_GET_CRL;
break;
+ case X509_V_ERR_CERT_SIGNATURE_FAILURE:
+ case X509_V_ERR_CRL_SIGNATURE_FAILURE:
+ failures |= SERF_SSL_SIGNATURE_FAILURE;
+ break;
Review Comment:
This looks like unrelated change.
Also I suggest to add separate flag for Certificate and CRL signature
failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@serf.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
