chemodax commented on code in PR #6:
URL: https://github.com/apache/serf/pull/6#discussion_r2160171234
##########
.github/workflows/windows-cmake.yml:
##########
@@ -44,21 +44,29 @@ jobs:
- uses: actions/checkout@v3
+ - name: Prepare Environment (Windows)
+ if: runner.os == 'Windows'
+ run: |
+ $root = "C:\Program Files\Microsoft Visual Studio\2022\Enterprise"
+ Import-Module
"$root\Common7\Tools\Microsoft.VisualStudio.DevShell.dll"
+ Enter-VsDevShell -VsInstallPath $root -DevCmdArguments "-arch=${{
matrix.arch }}"
+
+ ls env: | foreach { "$($_.Name)=$($_.Value)" >> $env:GITHUB_ENV }
+
- name: Configure CMake
run: >
cmake
-B ${{github.workspace}}/build
-G "${{ matrix.generator }}"
- -DCMAKE_GENERATOR_PLATFORM=${{ matrix.platform }}
-DCMAKE_TOOLCHAIN_FILE=C:/vcpkg/scripts/buildsystems/vcpkg.cmake
-DCMAKE_PREFIX_PATH=C:/vcpkg/installed/${{ matrix.triplet }}
-DCMAKE_INSTALL_PREFIX=${{github.workspace}}/install
- name: Build (Release)
- run: cmake --build ${{github.workspace}}/build --config Release -j
Review Comment:
These changes seems to be unrelated to the pull request (while I support the
change itself).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@serf.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
