brainy commented on PR #6: URL: https://github.com/apache/serf/pull/6#issuecomment-2993831073
> I think this was discussed on the list. I can't really judge the implications of one over the other. It was mentioned onlist where @rinrab had some arguments in favour of moving to Ninja. > > @brainy Do you have a strong feeling about keeping VS? Guys, slow down. I keep hearing this "Ninja is faster" argument, but has anyone bothered to actually **look** at what's making the Windows build so slow? Hint: it's not MSBuild. Besides, there's another, more fundamental problem with the CMake build: the debug build doesn't use the debug-mode dependencies that were installed by vcpkg, and consequently, a test is failing. 10 internet points to anyone who tells me why (I know the answer). This is a direct consequence of CMake being fundamentally broken at the architecture level. No amount of using different generators will fix that. To summarize, messing around with Ninja versus VS does exactly nothing to improve the build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@serf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
