On 23. 6. 25 14:12, Daniel Sahlberg wrote:
Hi,

Someone complained that the files in the 1.3.9 release tarball have
rw-rw-rw- mode. In the 1.3.10 release tarball the files are rw-rw-r--.

Danielsh suggested to set the umask to 022 before the svn export step,
something like this:

[[[
Index: dist.sh
===================================================================
--- dist.sh     (revision 1926662)
+++ dist.sh     (working copy)
@@ -27,6 +27,9 @@
  mkdir "${work}"
  cd "${work}"

+# SERF-181: Source tarball file mods are group- and world-writable
+umask 022
+
  echo "Exporting latest serf ..."
  svn export --quiet "${url}" "${release}" || exit 1
  echo "`find ${release} -type f | wc -l` files exported"
]]]

Anyone see a downside to this?

Not really. If the RM has some magic super-secret umask set, that'll be covered by "mkdir ${work}".

While you're there, you might consider throwing out the MD5 and SHA-1 checksumming and leaving SHA-512 (and maybe adding SHA-256).

Yes, yes, unrelated.

-- Brane

Reply via email to