Hi JB, Thanks for the advise. Do you mean we still need to copy the old license header of vertx file? Current we just use the standard Apache license header here[1]
[1] https://github.com/apache/incubator-servicecomb-java-chassis/blob/master/transports/transport-rest/transport-rest-vertx/src/main/java/org/apache/servicecomb/transport/rest/vertx/RestBodyHandler.java Willem Jiang Blog: http://willemjiang.blogspot.com (English) http://jnn.iteye.com (Chinese) Twitter: willemjiang Weibo: 姜宁willem On Fri, Jan 12, 2018 at 9:47 PM, Jean-Baptiste Onofré <j...@nanthrax.net> wrote: > Hi, > > as the code is already under Apache license, it's fine to copy code > including the header to give credit. > > Regards > JB > > > On 01/12/2018 03:18 AM, Willem Jiang wrote: > >> I think keep these two license header in the file should be fine. >> But I'd ask for help from our mentors @Roman and @JB. >> >> BTW, we may head the same issue in our Golang project Service Center. >> >> >> Willem Jiang >> >> Blog: http://willemjiang.blogspot.com (English) >> http://jnn.iteye.com (Chinese) >> Twitter: willemjiang >> Weibo: 姜宁willem >> >> On Fri, Jan 12, 2018 at 9:28 AM, wjm wjm <zzz...@gmail.com> wrote: >> >> io.servicecomb.transport.rest.vertx.RestBodyHandler is copied >>> from io.vertx.ext.web.handler.impl.BodyHandlerImpl, and do some modify >>> because we cannot extend io.vertx.ext.web.handler.impl.BodyHandlerImpl >>> to >>> change the behavior. >>> >>> We will try our best to submit the PR to the Vertx Community. But now we >>> just copy the file and do some change as a temporary solution. >>> >>> Should we just keep this two license headers in the >>> io.servicecomb.transport.rest.vertx.RestBodyHandler file? >>> >>> license of io.vertx.ext.web.handler.impl.BodyHandlerImpl is: >>> /* >>> * Copyright 2014 Red Hat, Inc. >>> * >>> * All rights reserved. This program and the accompanying materials >>> * are made available under the terms of the Eclipse Public License >>> v1.0 >>> * and Apache License v2.0 which accompanies this distribution. >>> * >>> * The Eclipse Public License is available at >>> * http://www.eclipse.org/legal/epl-v10.html >>> * >>> * The Apache License v2.0 is available at >>> * http://www.opensource.org/licenses/apache2.0.php >>> * >>> * You may elect to redistribute this code under either of these >>> licenses. >>> */ >>> >>> license of us is: >>> /* >>> * Licensed to the Apache Software Foundation (ASF) under one or more >>> * contributor license agreements. See the NOTICE file distributed with >>> * this work for additional information regarding copyright ownership. >>> * The ASF licenses this file to You under the Apache License, Version >>> 2.0 >>> * (the "License"); you may not use this file except in compliance with >>> * the License. You may obtain a copy of the License at >>> * >>> * http://www.apache.org/licenses/LICENSE-2.0 >>> * >>> * Unless required by applicable law or agreed to in writing, software >>> * distributed under the License is distributed on an "AS IS" BASIS, >>> * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or >>> implied. >>> * See the License for the specific language governing permissions and >>> * limitations under the License. >>> */ >>> >>> >> > -- > Jean-Baptiste Onofré > jbono...@apache.org > http://blog.nanthrax.net > Talend - http://www.talend.com >
