WillemJiang commented on a change in pull request #562: [SCB-358] fix bug for
monitor output id that register only name without any tags
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/562#discussion_r171295616
##########
File path:
foundations/foundation-metrics/src/test/java/org/apache/servicecomb/foundation/metrics/publish/TestMetricsLoader.java
##########
@@ -53,4 +54,15 @@ public void checkGetChildrenCount() {
MetricNode node = loader.getMetricTree("X", "K1");
Assert.assertEquals(2, node.getChildrenCount());
}
+
+ @Test
+ public void checkNoSuchId() throws Exception {
+ try {
+ loader.getMetricTree("Z");
+ throw new Exception("CheckFailed");
+ }
+ //ignore because throw exception is correct
+ catch (ServiceCombException ignore) {
+ }
Review comment:
We need to verify the ServiceCombException message here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
