WillemJiang commented on a change in pull request #562: [SCB-358] fix bug for
monitor output id that register only name without any tags
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/562#discussion_r171289410
##########
File path:
foundations/foundation-metrics/src/main/java/org/apache/servicecomb/foundation/metrics/publish/Metric.java
##########
@@ -35,14 +36,33 @@ public String getName() {
}
public Metric(String id, double value) {
- String[] nameAndTag = id.split("\\(");
- this.tags = new HashMap<>();
- String[] tagAnValues = nameAndTag[1].split("[=,)]");
- for (int i = 0; i < tagAnValues.length; i += 2) {
- this.tags.put(tagAnValues[i], tagAnValues[i + 1]);
+ if (isCorrectId(id)) {
+ this.tags = new HashMap<>();
+ this.value = value;
+ String[] nameAndTag = id.split("[()]");
+ if (nameAndTag.length == 1) {
+ if (!id.endsWith(")")) {
+ this.name = nameAndTag[0];
+ } else {
+ throw new ServiceCombException("bad format id");
Review comment:
Please add the id the message, otherwise the user cannot know which id is
wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
