+1
LGTM

2018-04-23 13:34 GMT+08:00 Zen Lin <[email protected]>:

> +1 nobinding
> Twice types of prefix should confuse the users and developers.
> I think it should be very nice if someone can findout and remove all the
> 'CSE' prefix in the whole project, but not only in the configuration.
>
> Best Regards,
> ---
> Zen Lin
> [email protected]
> Focused on Micro Service and Apache ServiceComb
>
> 2018-04-23 10:37 GMT+08:00 Jean-Baptiste Onofré <[email protected]>:
>
> > +1
> >
> > Regards
> > JB
> >
> > Le 23 avr. 2018 à 05:49, à 05:49, "郑扬勇" <[email protected]> a écrit:
> > >Hi ,all :
> > >we had support both style of configuration for a long time (since
> > >0.2.0):
> > >https://github.com/apache/incubator-servicecomb-java-chassis/pull/91
> > >   But all demos and samples in our code still use 'cse.xxx' such as :
> > >
> > > APPLICATION_ID: multiple
> > >service_description:
> > >  name: a-server
> > >  version: 0.0.1
> > >cse:
> > ><------- old
> > >  service:
> > >    registry:
> > >      address: http://127.0.0.1:30100
> > >  rest:
> > >    address: 0.0.0.0:8080
> > >  highway:
> > >    address: 0.0.0.0:7070
> > >
> > >I think it's time we may change all of them to 'servicecomb.xxx' like :
> > >
> > > APPLICATION_ID: multiple
> > >service_description:
> > >  name: a-server
> > >  version: 0.0.1
> > >servicecomb:
> > ><------- new
> > >  service:
> > >    registry:
> > >      address: http://127.0.0.1:30100
> > >  rest:
> > >    address: 0.0.0.0:8080
> > >  highway:
> > >    address: 0.0.0.0:7070
> > >
> > >  Any other ideas or suggestions are welcome !
> > >
> > > Yangyong Zheng
> > >Best Regards !
> >
>

Reply via email to