If we do have modified those libraries, it's better we make a fork of them on github and the use the forks.
It's still better that we use them directly as is to ease later upgrade and do the work in our code through wrappers. On Thu, Jun 7, 2018 at 11:32 AM, Willem Jiang <[email protected]> wrote: > If we changed the code, we should move it third party directory. > @Asif @Cuiyihua Could you double check with YangBo？ > > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > > On Thu, Jun 7, 2018 at 10:29 AM, Yang Bo <[email protected]> wrote: > > > Hi All, > > > > Currently we store github.com/go-ecosystem/grpc-gateway and > > go-grpc-prometheus under the vendor directory. > > > > The vendor directory should only contain manifest file and all other code > > should be fetched from third party repository. > > > > If we have made some modification to those libraries, then we need to > move > > them to a proper place. > > > > -- > > Best Regards, > > Yang. > > > -- Best Regards, Yang.
