Hi, The problem is fixed. I added the version information of the 2 libraries in manifest and removed the code.
Please check https://github.com/apache/incubator-servicecomb-service-center/pull/372 On Fri, Jun 8, 2018 at 10:58 AM, Sure <sure_0...@qq.com> wrote: > we do not change the code in go-ecosystem package and we can remove these > files from project > > > Just make sure the same version of this package compiled with etcd > components when make the release. > > > > > > ------------------ 原始邮件 ------------------ > 发件人: "willem.jiang"<willem.ji...@gmail.com>; > 发送时间: 2018年6月7日(星期四) 中午11:32 > 收件人: "dev"<dev@servicecomb.apache.org>; > > 主题: Re: [Discuss] Should we clean up vendor/github.com/go-ecosystem for > ServiceCenter > > > > If we changed the code, we should move it third party directory. > @Asif @Cuiyihua Could you double check with YangBo？ > > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > > On Thu, Jun 7, 2018 at 10:29 AM, Yang Bo <oaky...@gmail.com> wrote: > > > Hi All, > > > > Currently we store github.com/go-ecosystem/grpc-gateway and > > go-grpc-prometheus under the vendor directory. > > > > The vendor directory should only contain manifest file and all other code > > should be fetched from third party repository. > > > > If we have made some modification to those libraries, then we need to > move > > them to a proper place. > > > > -- > > Best Regards, > > Yang. > > > -- Best Regards, Yang.
