1.fork jackson-dataformats-binary to https://github.com/huaweicse 2.PR from huaweicse to jackson 3.deploy a special version jackson-dataformat-protobuf from huaweicse to huawei cse maven repository 4.before our features set be stable, we will depend jackson-dataformat-protobuf from huawei cse maven repository after be stable, we will depend on official jackson-dataformat-protobuf directly
2018-08-15 8:51 GMT+08:00 Willem Jiang <[email protected]>: > PMC means the ServiceComb PPMC, not the Jackson PMC. > So please share your plan and modification with us, and we will find out > the best way then. > > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > > On Wed, Aug 15, 2018 at 8:37 AM, wjm wjm <[email protected]> wrote: > > > seems that: > > 1.base code not change license > > 2.new class " should be dealt with on a case-by-case basis by the PMC ", > > the PMC is jackson PMC or us? > > > > 2018-08-15 8:33 GMT+08:00 Willem Jiang <[email protected]>: > > > > > If we write the code from scratch, we should apply the ASF license > > header. > > > > > > If there are third party code was add to the repo, we need to keep the > > old > > > license header. > > > Please go through this document[1] for more information. > > > > > > [1] https://www.apache.org/legal/src-headers.html#3party > > > > > > > > > Willem Jiang > > > > > > Twitter: willemjiang > > > Weibo: 姜宁willem > > > > > > On Wed, Aug 15, 2018 at 8:27 AM, wjm wjm <[email protected]> wrote: > > > > > > > if create a module in our repo, then how to process the license? > > > > follow jackson or us? > > > > is it different between base code and new code. > > > > > > > > 2018-08-15 6:06 GMT+08:00 Willem Jiang <[email protected]>: > > > > > > > > > The best way is we send the PR jackson master branch, it can > benefit > > > all > > > > of > > > > > us. > > > > > > > > > > It depends on the release time schedule. If we cannot wait for the > > > > release > > > > > of jackson, we may have to create a module in our repo. And we > change > > > to > > > > > use the jackson once the change is merged. > > > > > > > > > > Is there any other reason to hold us back for upgrading the jackson > > > > > version? > > > > > > > > > > > > > > > > > > > > Willem Jiang > > > > > > > > > > Twitter: willemjiang > > > > > Weibo: 姜宁willem > > > > > > > > > > On Wed, Aug 15, 2018 at 4:06 AM, wjm wjm <[email protected]> wrote: > > > > > > > > > > > another information: > > > > > > jackson master version is 3.x > > > > > > modification for 2.9.6 is different to 3.x, many jackson base > class > > > > > changed > > > > > > > > > > > > 2018-08-15 2:33 GMT+08:00 wjm wjm <[email protected]>: > > > > > > > > > > > > > i had already extend jackson protobuf to support protobuf3 map > > > > feature. > > > > > > > > > > > > > > based on jackson 2.9.6, because we are using 2.9.6 > > > > > > > but jackson 2.9.6 already released. > > > > > > > even i raise a PR for this and jackson will merge it, we can > not > > > use > > > > it > > > > > > > directly or must wait for next release. > > > > > > > > > > > > > > but we must start new task based on this feature right now. > > > > > > > > > > > > > > so how to resolve the confliction? > > > > > > > > > > > > > > > > > > > > > > > > > > > >
