+1 for Option2. Option 2 is much better, as it won't block the development of the master branch.
Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Mon, Oct 28, 2019 at 2:24 PM Daniel Qian <chanjars...@gmail.com> wrote: > > Since oas-validator donation process is finished (see this [1]) so > next is to decide how to import oas-validator code into toolkit > project. > > IMO, the first thing is merging the code ASAP, after that we will > discuss how to integrating. > > I have two options: > > 1. Unzip the code archive and create a directory for it, push it to > toolkit master branch > 2. Create a branch on toolkit repo, unzip the code archive and create > a directory for it, push it to that branch, after integration finished > merge that branch to master > > Any ideas? > > [1] https://issues.apache.org/jira/browse/INCUBATOR-247 > > > -- > Daniel Qian > > 博客:https://segmentfault.com/u/chanjarster > github:https://github.com/chanjarster