Ok, let's do option 2. Please tell me when the branch is created, so I can make a PR for it, is suggest the branch name be import-oas-validator
Willem Jiang <willem.ji...@gmail.com> 于2019年10月29日周二 上午8:10写道： > > +1 for Option2. > Option 2 is much better, as it won't block the development of the > master branch. > > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > > On Mon, Oct 28, 2019 at 2:24 PM Daniel Qian <chanjars...@gmail.com> wrote: > > > > Since oas-validator donation process is finished (see this [1]) so > > next is to decide how to import oas-validator code into toolkit > > project. > > > > IMO, the first thing is merging the code ASAP, after that we will > > discuss how to integrating. > > > > I have two options: > > > > 1. Unzip the code archive and create a directory for it, push it to > > toolkit master branch > > 2. Create a branch on toolkit repo, unzip the code archive and create > > a directory for it, push it to that branch, after integration finished > > merge that branch to master > > > > Any ideas? > > > > [1] https://issues.apache.org/jira/browse/INCUBATOR-247 > > > > > > -- > > Daniel Qian > > > > 博客：https://segmentfault.com/u/chanjarster > > github：https://github.com/chanjarster -- Daniel Qian 博客：https://segmentfault.com/u/chanjarster github：https://github.com/chanjarster
