+0 I've created two PRs corresponding to Willem Jiang's suggestions:
https://github.com/apache/servicecomb-toolkit/pull/75
https://github.com/apache/servicecomb-toolkit/pull/76
So, I think it's better to create another RC.
BTW,

1. Not all issues for toolkit 0.2.0 are closed
2. all the links above are fine.
3. git tag and commit id are OK.
4. hashes and signature are good.
5. license and Notice exist
6. scripts/test.sh build is OK
7. toolkit-maven-plugin running is OK.

zhongyuan zhou <zhouzhongyua...@gmail.com> 于2020年1月3日周五 上午10:41写道:
>
> +1
>
> I checked :
>  - hashes and signature are good.
>  - mvn clean install works fine.
>
> Bin Ma <mabin1...@gmail.com> 于2020年1月3日周五 上午9:15写道:
>
> > +1 binding
> >
> > I checked:
> > 1. all issues for toolkit 0.2.0 are closed
> > 2. all the links above are fine.
> > 3. git tag and commit id are OK.
> > 4. hashes and signature are good.
> > 5. license and Notice exist
> > 6. mvn clean install build OK.
> > 7. toolkit-maven-plugin running is OK.
> >
> >
> > Wishes & Regards
> > -------------------------------
> > Mabin
> >
> >
> >
> > Liubao (A) <bao....@huawei.com> 于2020年1月2日周四 下午8:24写道:
> >
> > > +1
> > >
> > > I checked the release binaries and release notes, seems good to me.
> > >
> > > Bug I got one small improvement for artifacts deployed by toolkit. May of
> > > the artifacts have very general name and may cause conflicts easily. e.g.
> > > toolkit*jar, core*jar, common*jar. Although the have unit group id, java
> > > packagers will put them all in one flat folder.
> > >
> > > -----邮件原件-----
> > > 发件人: sen sun [mailto:asd992825...@gmail.com]
> > > 发送时间: 2019年12月31日 18:18
> > > 收件人: dev@servicecomb.apache.org
> > > 主题: [VOTE] Release Apache ServiceComb Toolkit version 0.2.0 [RC2]
> > >
> > > Hi All,
> > >
> > > This is a call for Vote to release Apache ServiceComb Toolkit version
> > 0.2.0
> > >
> > >
> > > Release Candidate :
> > >
> > >
> > https://dist.apache.org/repos/dist/dev/servicecomb/servicecomb-toolkit/0.2.0/rc-02/
> > >
> > > Staging Repository :
> > >
> > >
> > https://repository.apache.org/content/repositories/orgapacheservicecomb-1411
> > >
> > > Release Tag :
> > > https://github.com/apache/servicecomb-toolkit/releases/tag/0.2.0
> > >
> > > Release CommitID : da3b3b6333e1c776d4e39513e39e328596d9b40f
> > >
> > > Release Notes :
> > >
> > >
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626&version=12346158
> > >
> > > Keys to verify the Release Candidate :
> > > https://dist.apache.org/repos/dist/dev/servicecomb/KEYS
> > >
> > > Voting will start now ( Tuesday, 31nd Dec, 2019) and will remain open for
> > > at-least 72 hours, Request all PMC members to give their vote.
> > >
> > > [ ] +1 Release this package as 0.2.0
> > > [ ] +0 No Opinion
> > > [ ] -1 Do not release this package because....
> > >
> > > On the behalf of ServiceComb Team
> > >
> > > Best Wishes & Regards
> > >
> >



-- 
Daniel Qian
Apache Committer(chanjarster)
blog:https://chanjarster.github.io
github:https://github.com/chanjarster
segmentfault: https://segmentfault.com/u/chanjarster

Reply via email to