[
https://issues.apache.org/activemq/browse/SM-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42208#action_42208
]
Ron Gavlin commented on SM-1305:
--------------------------------
1. Your patch is true to the original lw-container code which makes SMX
maintenance a bit easier. However, I think these helper classes should
primarily focus on making it easier for developers to write servicemix-beans. I
can't think of a use case in which someone would use BeanPojoSupport directly.
So, separating BeanPojoSupport from BeanComponentSupport, from my perspective,
just adds needless complication. I would suggest these be consolidated into one
class.
2. The presence of "Component" in the name seems like a legacy lw-container
holdover so I would recommend removing it from the names of both classes.
3. It would also be useful to include "public QName getService()" and "public
String getEndpoint()" helper methods in helper class
Bean(Component)Support.java.
> Provide convenient base classes to simplify servicemix-bean component
> development (including IN-only MEP Transforms)
> --------------------------------------------------------------------------------------------------------------------
>
> Key: SM-1305
> URL: https://issues.apache.org/activemq/browse/SM-1305
> Project: ServiceMix
> Issue Type: New Feature
> Components: servicemix-bean
> Affects Versions: 3.2.1
> Reporter: Ron Gavlin
> Attachments: lw2smbean.zip
>
>
> The deprecated, LightWeight container provided a convenient base class,
> TransformComponentSupport, that made it easy for non-JBI experts to write
> simple transforms in Java. In order to accomplish the same task with
> servicemix-bean, a developer must have have in-depth, JBI knowledge. A helper
> class or base class should be created to make it easier for developers to
> write transforms using servicemix-bean. A base class would also be useful to
> ease the implementation of non-Transform servicemix-beans.
> I suggest the following class names for the proposed two base classes:
> 1. org.apache.servicemix.bean.support.BeanSupport.java - this class provides
> servicemix-bean specific functionality currently offered by the combination
> of "org.apache.servicemix.components.util.PojoSupport.java" and
> "org.apache.servicemix.components.util.ComponentSupport.java"
> 2. org.apache.servicemix.bean.support.TransformBeanSupport.java - this class
> extends "org.apache.servicemix.bean.support.BeanSupport.java" (above),
> implements MessageExchangeListener, and provides servicemix-bean specific
> functionality currently offered by
> "org.apache.servicemix.components.util.TransformComponentSupport.java"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
