[ 
https://issues.apache.org/activemq/browse/SM-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42280#action_42280
 ] 

Guillaume Nodet commented on SM-1305:
-------------------------------------

I totally agree with points 1 and 2.
On point 3, I'm not sure what these getters would be used for (getService / 
getEndpoint).  Are you thinking about the target endpoint or the endpoint using 
that bean ?  In both cases, I think this won't work well.
A few more comments on the patch:
  * I would also get rid of the isExchangeWithXxxOkay, because they won't be 
used at all.
  * for the transformer support, in case an InOnly exchange is received, the 
transformed response will be sent also as an InOnly, but currently, no target 
is specified.  I would use the exchange-target element of servicemix-eip or 
something along those lines to specify the target.

> Provide convenient base classes to simplify servicemix-bean component 
> development (including IN-only MEP Transforms)
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: SM-1305
>                 URL: https://issues.apache.org/activemq/browse/SM-1305
>             Project: ServiceMix
>          Issue Type: New Feature
>          Components: servicemix-bean
>    Affects Versions: 3.2.1
>            Reporter: Ron Gavlin
>         Attachments: lw2smbean.zip
>
>
> The deprecated, LightWeight container provided a convenient base class, 
> TransformComponentSupport, that made it easy for non-JBI experts to write 
> simple transforms in Java. In order to accomplish the same task with 
> servicemix-bean, a developer must have have in-depth, JBI knowledge. A helper 
> class or base class should be created to make it easier for developers to 
> write transforms using servicemix-bean. A base class would also be useful to 
> ease the implementation of non-Transform servicemix-beans. 
> I suggest the following class names for the proposed two base classes:
> 1. org.apache.servicemix.bean.support.BeanSupport.java - this class provides 
> servicemix-bean specific functionality currently offered by the combination 
> of "org.apache.servicemix.components.util.PojoSupport.java" and 
> "org.apache.servicemix.components.util.ComponentSupport.java"
> 2. org.apache.servicemix.bean.support.TransformBeanSupport.java - this class 
> extends "org.apache.servicemix.bean.support.BeanSupport.java" (above), 
> implements MessageExchangeListener, and provides servicemix-bean specific 
> functionality currently offered by 
> "org.apache.servicemix.components.util.TransformComponentSupport.java"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to