[
https://issues.apache.org/activemq/browse/SM-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48993#action_48993
]
Christian Mueller commented on SM-1623:
---------------------------------------
Hi Lars hi Jean-Baptiste,
Thanks. Yes, the 'SmppXBeanDeployerTest' and 'SpringComponentTest' tests are
integration tests. They need a running Short Message Service Center. Should
we move this tests to 'src/it/java' or anywhere else? Maybe, maven plans to
support the 'integration-test phase in future (
http://docs.codehaus.org/display/MAVENUSER/Maven+and+Integration+Testing).
Also, I'm agree with you, we should provide 'real' unit tests with a mock
implementation.
Jean-Baptiste, on which todo's you plan concrete to work? Because the
overlap... :-)
I would like to start with the unit tests for SmppConsumerEndpoint and
SmppProviderEndpoint.
Do you have a prefered mock library? I'm familiar with
easymock/easymock-classextension...
And one more feature would be useful for our clients. Specify the duration,
a enquire link request will be send to the SMSC. At the moment, every 5
seconds a request is send. In our production env, we need a enquire link
only at 4 minutes...
You agree with this offer, to add a enquireLinkPeriod attribute to the
consumer/provider?
Christian
> New binding component: SMPP
> ---------------------------
>
> Key: SM-1623
> URL: https://issues.apache.org/activemq/browse/SM-1623
> Project: ServiceMix
> Issue Type: Improvement
> Components: servicemix-components
> Reporter: Rohit Joshi
> Assignee: Jean-Baptiste Onofré
> Attachments: DefaultSmppMarshalerTest.patch, pom.xml.patch,
> smpp_consumer_endpoint.patch, SmppSenderEndpoint.java.patch,
> SmppSenderEndpoint.java.patch, SmppXBeanDeployerTest.patch,
> SpringComponentTest.patch
>
>
> I am submitting here source code for SMPP binding component. See the
> attached tar file.
> Attached servicemix-component.tar file contains following files. It should be
> deployed under apache-servicemix-3.2.2/src/common directory.
> ********
> SOURCE
> ***********
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/SMPPMarshaler.java
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/SMPPPoller.java
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/SMPPSender.java
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/servicemix.xml
> ******
> TEST
> ********
> servicemix-components/src/test/java/org/apache/servicemix/components/smpp/
> servicemix-components/src/test/java/org/apache/servicemix/components/smpp/SMPPPollTest.java
> servicemix-components/src/test/java/org/apache/servicemix/components/smpp/SMPPTest.java
> *********
> pom.xml
> ********
> servicemix-components/pom.xml
> this file adds the dependency on smppapi.
> <dependency>
> <groupId>smppapi</groupId>
> <artifactId>smppapi</artifactId>
> <version>0.3.7</version>
> <optional>false</optional>
> </dependency>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
