[
https://issues.apache.org/activemq/browse/SM-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=49028#action_49028
]
Christian Mueller commented on SM-1623:
---------------------------------------
Hi Lars, hi Jean-Baptiste,
I worked yesterday on simple unit tests for SmppProviderEndpoint and
SmppConsumerEndpoint and found the following failures:
- NPE in SmppConsumerEndpoint if no marshaler is explicit provided
- validation of the availability of the password in SmppProviderEndpoint,
because the password is optional
At the moment, I can't submit a patch because I have the uncommited changes
from Jean-Baptists last patch in my workspace... If the patch is commited, I
will submit the patch.
Jean-Baptiste, just to clarify: You will implement the unit tests for
SmppProviderEndpoint and SmppConsumerEndpoint which starts automaticly (in
setUp() method) the SMPPSim or something else?
Christian
> New binding component: SMPP
> ---------------------------
>
> Key: SM-1623
> URL: https://issues.apache.org/activemq/browse/SM-1623
> Project: ServiceMix
> Issue Type: Improvement
> Components: servicemix-components
> Reporter: Rohit Joshi
> Assignee: Jean-Baptiste Onofré
> Attachments: DefaultSmppMarshalerTest.patch, endpointTimers.patch,
> pom.xml.patch, smpp_consumer_endpoint.patch, SmppSenderEndpoint.java.patch,
> SmppSenderEndpoint.java.patch, SmppXBeanDeployerTest.patch,
> SpringComponentTest.patch
>
>
> I am submitting here source code for SMPP binding component. See the
> attached tar file.
> Attached servicemix-component.tar file contains following files. It should be
> deployed under apache-servicemix-3.2.2/src/common directory.
> ********
> SOURCE
> ***********
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/SMPPMarshaler.java
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/SMPPPoller.java
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/SMPPSender.java
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/servicemix.xml
> ******
> TEST
> ********
> servicemix-components/src/test/java/org/apache/servicemix/components/smpp/
> servicemix-components/src/test/java/org/apache/servicemix/components/smpp/SMPPPollTest.java
> servicemix-components/src/test/java/org/apache/servicemix/components/smpp/SMPPTest.java
> *********
> pom.xml
> ********
> servicemix-components/pom.xml
> this file adds the dependency on smppapi.
> <dependency>
> <groupId>smppapi</groupId>
> <artifactId>smppapi</artifactId>
> <version>0.3.7</version>
> <optional>false</optional>
> </dependency>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
