[
https://issues.apache.org/activemq/browse/SM-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=49073#action_49073
]
Christian Mueller commented on SM-1623:
---------------------------------------
Hi Jean-Baptiste,
sounds good... Do you mean, you start this SmppServerMock in the tests setUp
method and this mock listen on a tcp port and will return a default/mock
response for a given request?
One thing I notices for two days. SmppConsumerEndpoint and
SmppProviderEndpoint have the same attributes and the same validate method.
Should they have the same super class? Maybe AbstractSmppEndpoint...
If Lars accept and commited your patch, I will apply the patch I announced
two days ago (fixed the NPE in SmppConsumerEndpoint if no marshaler is
explicit provided; wrong validation of the availability of the password in
SmppProviderEndpoint, because the password is optional)
In my next free time, I will looking for a better catch of exceptions on the
jsmpp level, you wrote few days ago...
Christian
> New binding component: SMPP
> ---------------------------
>
> Key: SM-1623
> URL: https://issues.apache.org/activemq/browse/SM-1623
> Project: ServiceMix
> Issue Type: Improvement
> Components: servicemix-components
> Reporter: Rohit Joshi
> Assignee: Jean-Baptiste Onofré
> Attachments: DefaultSmppMarshaler.java.patch,
> DefaultSmppMarshaler.java.patch, DefaultSmppMarshalerTest.patch,
> endpointTimers.patch, pom.xml.patch, smpp_consumer_endpoint.patch,
> SmppSenderEndpoint.java.patch, SmppSenderEndpoint.java.patch,
> SmppXBeanDeployerTest.patch, SpringComponentTest.patch
>
>
> I am submitting here source code for SMPP binding component. See the
> attached tar file.
> Attached servicemix-component.tar file contains following files. It should be
> deployed under apache-servicemix-3.2.2/src/common directory.
> ********
> SOURCE
> ***********
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/SMPPMarshaler.java
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/SMPPPoller.java
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/SMPPSender.java
> servicemix-components/src/main/java/org/apache/servicemix/components/smpp/servicemix.xml
> ******
> TEST
> ********
> servicemix-components/src/test/java/org/apache/servicemix/components/smpp/
> servicemix-components/src/test/java/org/apache/servicemix/components/smpp/SMPPPollTest.java
> servicemix-components/src/test/java/org/apache/servicemix/components/smpp/SMPPTest.java
> *********
> pom.xml
> ********
> servicemix-components/pom.xml
> this file adds the dependency on smppapi.
> <dependency>
> <groupId>smppapi</groupId>
> <artifactId>smppapi</artifactId>
> <version>0.3.7</version>
> <optional>false</optional>
> </dependency>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
