[
https://issues.apache.org/activemq/browse/SMX4KNL-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=50484#action_50484
]
Guillaume Nodet commented on SMX4KNL-239:
-----------------------------------------
I have quickly reviewed the patch and have a few comments:
* the patch on {{etc/config.properties}} seems inapropriate
* the patch on completers seems is already on trunk afaik (you should svn up
before creating your patch)
* did you disabled uninstallation in the FeatureDeploymentListener on purpose
?
* what is the purpose of setting the repository URI on the feature itself ? a
feature is contained by a repository already
* i don't understand the need to maintain a list of installed repositories: a
repository is just a list of features the why not simply saying that installing
a repo installs all the features in that repo, and uninstalling a repository
uninstalls all the features from a repo ? I don't really see a repository as
being something installed, it's really just a list of features.
> Install/Un-install of a features repository through JMX Frontend
> ----------------------------------------------------------------
>
> Key: SMX4KNL-239
> URL: https://issues.apache.org/activemq/browse/SMX4KNL-239
> Project: ServiceMix Kernel
> Issue Type: Sub-task
> Reporter: Edell Nolan
> Assignee: Edell Nolan
> Fix For: 1.2.0
>
> Attachments: install-uninstall.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
