[
https://issues.apache.org/activemq/browse/SMX4KNL-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=50488#action_50488
]
Chris Custine commented on SMX4KNL-239:
---------------------------------------
Some comments and addressing some of Guillaume's issues:
* The patch on the completers all seem new to me, although the @PostConstruct
in ConfigurationCompleter should be harmless.
* I recommend splitting the FeatureRepositoryCompleter out into
InstalledRepositoryCompleter and AvailableRepositoryCompleter or something like
that because we can't really control how this gets called from the shell (so
the installed boolean flag can never be used properly).
* The {{/etc/config.properties}} patch is definitely not a good idea, but it
looks like that was accidentally included in the patch set?
* The uninstall bundle event handler in FeatureDeploymentListener doesn't work
because the events are called *AFTER* the bundle is uninstalled, and this is
according to the OSGi spec. We'll have to find another way to track those.
> Install/Un-install of a features repository through JMX Frontend
> ----------------------------------------------------------------
>
> Key: SMX4KNL-239
> URL: https://issues.apache.org/activemq/browse/SMX4KNL-239
> Project: ServiceMix Kernel
> Issue Type: Sub-task
> Reporter: Edell Nolan
> Assignee: Edell Nolan
> Fix For: 1.2.0
>
> Attachments: install-uninstall.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
