[
https://issues.apache.org/activemq/browse/SMXCOMP-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=50727#action_50727
]
Ron Gavlin commented on SMXCOMP-474:
------------------------------------
Shouldn't the isRollbackOnError flag be ignored if the endpoint is not
transacted. For non-transacted endpoints, it seems non-intuitive for the value
of a transaction-specific flag to impact behavior. I am afraid it will also
introduce backwards compatibility problems for non-transacted endpoints.
For example, in your updated in-out MEP unit test, I see the isRollbackOnError
flag is being explicitly set to false. Since it is unusual for an in-out MEP to
be transacted, it seems quite inconvenient and non-intuitive to be forced to
explicitly set this flag to false. Again, it may also break
backwards-compatibility.
Would you entertain a patch that only considers the isRollbackOnError value if
the endpoint/returned exchange is transacted?
/Ron
> Regression introduced in servicemix-jms default consumer which does not
> rollback the transactions by default when an exchange with an ERROR status
> comes back
> -------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SMXCOMP-474
> URL: https://issues.apache.org/activemq/browse/SMXCOMP-474
> Project: ServiceMix Components
> Issue Type: Bug
> Components: servicemix-jms
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Fix For: 3.2.4, servicemix-jms-2009.01
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
