Hi Raul,

Yeah, that looks like something I messed up on Friday when I added the
license headers that were missing from some of the files.  We
concatenate a separate file with the OBR stuff to the existing
startup.properties file - looks like on your platform at least,
there's a problem with the line endings when doing that.  Perhaps
adding a newline to the beginning of the file we append (with the OBR
stuff) is enough to fix this?

Good catch - I agree with you: let's fix this and cut a new release candidate.


Regards,

Gert Vanthienen


On Sun, Mar 16, 2014 at 8:49 PM, Raul Kripalani <[email protected]> wrote:
> Hello,
>
> I did a clean build and started the resulting instance. Unfortunately I
> came across this message while starting up:
>
> Please wait while Apache ServiceMix is starting...
> Ignoring
> /Users/raul/Workbench/apache-servicemix-5.0.0/system/org/apache/karaf/deployer/org.apache.karaf.deployer.wrap/2.3.4/org.apache.karaf.deployer.wrap-2.3.4.jar
> (run level must be an integer)
>
> The root cause is that the concatenation of startup.properties from the
> Karaf distro with our OBR variant leads to this result:
>
> org/apache/karaf/deployer/org.apache.karaf.deployer.wrap/2.3.4/org.apache.karaf.deployer.wrap-2.3.4.jar=30#
> #    Licensed to the Apache Software Foundation (ASF) under one or more
> #    contributor license agreements.  See the NOTICE file distributed with
>
> Notice the trailing comment pound. Could be due to any or many of several
> reasons: Karaf 2.3.4 has removed the trailing at the end of their
> startup.properties file or license header was added recently; newlines are
> not handled properly after we merged the Windows + Unix distros; etc.
>
> It definitely must be a platform-specific issue, given that the rest of you
> haven't come across it... Did you guys build from scratch? Or did you use
> RC binaries to test?
>
> I cannot effectively -1 this candidate since I'm not a committer, but as a
> user I would expect SMX5 to provide a seamless and flawless experience. My
> 2 cent.
>
> P.S.: Working on a patch.
>
> Regards,
>
> *Raúl Kripalani*
> Apache Camel PMC Member & Committer | Enterprise Architect, Open Source
> Integration specialist
> http://about.me/raulkripalani | http://www.linkedin.com/in/raulkripalani
> http://blog.raulkr.net | twitter: @raulvk
>
> On Fri, Mar 14, 2014 at 2:11 PM, Gert Vanthienen
> <[email protected]>wrote:
>
>> L.S.,
>>
>>
>> We've uploaded a release for Apache ServiceMix 5.0.0 to
>>
>> https://repository.apache.org/content/repositories/orgapacheservicemix-1004/
>>
>> An overview of issues fixed in this release can be found in JIRA at
>>   https://issues.apache.org/jira/browse/SM/fixforversion/12324078
>>
>> The scm tag is available on
>>   http://svn.apache.org/repos/asf/servicemix/smx5/tags/servicemix-5.0.0/
>>
>> Please vote to approve this release:
>>
>> [ ] +1 Approve the release
>> [ ] -1 Do not approve the release (please provide specific comments)
>>
>> This vote will be open for 72 hours.
>>
>>
>> Regards,
>>
>> Gert Vanthienen
>>

Reply via email to