As long the drools feature has no dependency to ServiceMix it should work with the separate lifecycle. We have only to ensure, the drools feature doesn't force a fixed version of camel etc. It could be done using version ranges. Having separate features which don't depend on ServiceMix core makes it easier installable outside ServiceMix, e.g. Karaf. But it was only my thought for the future.
Having the feature in ServiceMix code base gives us more flexibility. We can try to patch the drools karaf features. When we achieve the state which doesn't force the concrete Camel and CXF version there is no reason to maintain the fatures in ServiceMix. I think this proposal is ok. Regards Krzysztof On 14.04.2015 13:33, Grzegorz Hałajko wrote: > Nice. org.apache.servicemix.drools it will be better. > > So. My proposal > > https://github.com/cybermaniax/servicemix/commit/e48a3f21cd598a40b57aa329791bb1a7d79ef435 > > > With separate repository will be difficult maintenance relation between SM > and features in that repository. > For example which project should be released earlier SM or > servicemix-features. > > drools-karaf-features have own lifecycle but without relation with SM. > Maybe it's better to do a patch to drools-karaf-features ? > > > 2015-04-14 11:23 GMT+02:00 Krzysztof Sobkowiak <[email protected]>: > >> Hi Grzegorz >> >> >> I think, you mean ServiceMix 6.0.0. >> >> It looks good for me. I prefer the modularized version of the feature >> (exactly like it looks now). It is more flexible >> and can be better extended with additional features. >> >> We can eventually create a new maven submodule drools >> (org.apache.servicemix/drools) in ServiceMix. It could contain a >> submodule feature(org.apache.servicemix.drools/feature) containing this >> feature. Your feature would be accessible with ulr: >> >> mvn:org.apache.servicemix.drools/feature/6.0.0-SNAPSHOT/xml/feature >> >> >> We can think once (when haveng more such features) about extracting this >> submodule in a separate repository (something >> like servicemix-features) with own lifecycle. >> >> We have already an issue for the new feature >> https://issues.apache.org/jira/browse/SM-2497 >> >> >> Regards >> Krzysztof >> >> >> >> On 14.04.2015 10:40, Grzegorz Hałajko wrote: >>> Hi >>> >>> >>> I would like to add Drools 6.2 to SerwiceMix 6.2 >>> >>> And this is my proposal: >>> >>> >> https://github.com/cybermaniax/servicemix/commit/00e0c8480e0d8f3f46f552e20c5bc44a52be8411 >>> New feature will be >>> "mvn:org.apache.servicemix/apache-servicemix/6.0.0-SNAPSHOT/xml/drools6" >>> >>> I was inspired by drools-karaf-features but in my version I changed >>> versions in external bundles (e.g. camel , cxf ) to supported in >>> ServiceMix. >>> >>> Also I see another way to create features.xml. One big feature e.g >> drools6 >>> with all bundles (kie,drools,jbpm), from projekt and another three >>> supported camel, spring and blueprint. >>> >>> What do you think? >>> >>> Regards >>> GH >>> >>> >> -- >> Krzysztof Sobkowiak >> >> JEE & OSS Architect >> Apache Software Foundation Member >> Apache ServiceMix <http://servicemix.apache.org/> Committer & PMC chair >> Senior Solution Architect @ Capgemini SSC < >> http://www.pl.capgemini-sdm.com/en/> >> > > -- Krzysztof Sobkowiak JEE & OSS Architect Apache Software Foundation Member Apache ServiceMix <http://servicemix.apache.org/> Committer & PMC chair Senior Solution Architect @ Capgemini SSC <http://www.pl.capgemini-sdm.com/en/>
