Hi Peter,
On 22 Nov 2005, at 05:29, Peter Smith wrote:
FYI....here's a few minor issues/questions I found while looking a
bit closer at how ServiceMix deploy/install works.
cheers,
Peter.
=============
#1 Page http://servicemix.org/Configuration described attributes
- monitorInstallationDirectory
- monitorDeploymentDirectory
But I can't see any evidence in the code that
monitorDeploymentDirectory attribute even exists. In fact, you can
see that AutoDeploymentService is monitoring both directories and
it is only checking isMonitorInstallationDirectory()
So it seems the code does not match the docs...or vice versa
Can you raise a jira issue ? I'll make sure the options is supported
==========
#2 JBIContainer - typo in javadoc
/**
* @return the AutomDeploymentService
*/
thx!
===========
#3 AutoDeploymentService. It seems like the monitorInterval can be
changed ONLY via JMX. There seems no equivalent JBIContainer
attribute. Maybe there's not supposed to be... or maybe an
accidental omission?
raise a jira issue ?
===========
#4 The test 'logger-component-1.0-jbi-installer.zip' description
(in the jbi.xml) says "An example of a Quartz JBI componet..." -
looks like cut/paste error
(typo "componet" so the original is also wrong)
thx - if there's any miss-spellings - I'm usually the culprit
===========
#5 updateArchive method has code
if (installationService.unloadInstaller
(componentName, true)) {
}
but there is no statements in that code block...were there meant to
be ;-)
er - yep - fixing ...
==========
#6 It seems that there is little difference between the ServiceMix
'deploy' and 'install' directories? In fact it looks like
ServiceMix decides the processing:
a) component installation, or
b) service assembly deployment, or
c) shared libs
...based only on looking at the jbi.xml and the directory name
doesn't seem to come into it at all.
Or am I mistaken? If not, I'm starting to wonder why (if everything
is interchangeable) there wasn't just a single dir where you just
dump anything you want auto-detected?
Correct - in fact you can still dump everything in the installation
directory only and it will be deployed. There's a separation between
installation and deployment mainly to distinguish between the two
tasks - because the behaviour is different - though it did start off
as only being one directory for auto installation/deployment - I
think the current way is a lot cleaner.
==========
#7 I think the directory structure diagram shown by http://
servicemix.org/Configuration is not quite right because it shows
'wdir' as the top level directory but I think that is a user-
configured name. See attribute rootDir of the JBIContainer - the
default name is 'rootDir'; not 'wdir'
thx!
[END]
Again, thanks Peter for this help!
cheers,
Rob
