Re: [servicemix-dev] ServiceMix deploy/install - some issues/questions

[Peter Smith]

Hi Rob,

Rob Davies wrote:

#1 Page http://servicemix.org/Configuration described attributes
- monitorInstallationDirectory
- monitorDeploymentDirectory

But I can't see any evidence in the code that  
monitorDeploymentDirectory attribute even exists. In fact, you can  
see that AutoDeploymentService is monitoring both directories and  it 
is only checking isMonitorInstallationDirectory()

So it seems the code does not match the docs...or vice versa


Can you raise a jira issue ? I'll make sure the options is supported

SM-212

#3 AutoDeploymentService. It seems like the monitorInterval can be  
changed ONLY via JMX. There seems no equivalent JBIContainer  
attribute. Maybe there's not supposed to be... or maybe an  
accidental omission?

raise a jira issue ?

SM-213


#6 It seems that there is little difference between the ServiceMix  
'deploy' and 'install' directories? In fact it looks like  ServiceMix 
decides the processing:
a) component installation, or
b) service assembly deployment, or
c) shared libs
...based only on looking at the jbi.xml and the directory name  
doesn't seem to come into it at all.

Or am I mistaken? If not, I'm starting to wonder why (if everything  
is interchangeable) there wasn't just a single dir where you just  
dump anything you want auto-detected?


Correct - in fact you can still dump everything in the installation  
directory only and it will be deployed. There's a separation between  
installation and deployment mainly to distinguish between the two  
tasks - because the behaviour is different - though it did start off  
as only being one directory for auto installation/deployment - I  
think the current way is a lot cleaner.

It think the JBI spec is quite clear about distinction between 
"installation" & "deployment" but speaking personally as a new JBI user 
it is very easy to become muddled, so I can see that separate dirs could 
be "a lot cleaner" but only if the dirs get used as intended. Otherwise 
user muddlement remains as before and still nobody quite knows where to 
drop what.

So...

* Maybe after parsing the jbi.xml you could reject or log warnings if 
the archive was the wrong kind expected for the directory it was dropped in.

* In a few places the terminology in messages of  the 
AutoDeploymentService is used interchangeably. This doesn't help if I am 
already confused by the distinction :-). For example I think all the 
following messages can apply equally to deployment OR installation 
processing
log.info("Deploying an exploded jar/zip,  we will create a temporary jar 
for it.");
log.info("Deployment will now work from " + file.getAbsolutePath());
log.error("I/O error installing archive", e);
log.warn("Directory: " + root.getName() + ": Automatic install of " + 
file + " failed", e);
log.info("Directory: " + root.getName() + ": Finished installation of 
archive:  "  + file.getName());
log.warn("Automatic install of " + file + " failed", e);

cheers,
Peter.