On 12/4/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
Author: craigmcc
Date: Mon Dec 4 13:25:07 2006
New Revision: 482364
URL: http://svn.apache.org/viewvc?view=rev&rev=482364
Log:
First round of supporting events when DialogContextManager.create() or
DialogContextManager.remove() is called. You can now register listeners of
type DialogContextManagerListener on the DialogContextManager instance. One
remaining FIXME is to make it possible to be notified when DialogContextManager
instances themselves are placed in and out of service -- since these instances
are typically a session scoped managed bean, we need to do something
interesting in order to fire the necessary events.
Also did a bit of other cleanup:
* Renamed DialogListener to DialogContextListener (with associated
ripple effects on method names) for naming consistency
* Added synchronization in a couple of missing cases
* Provided getXxxxxListener() methods that returned an array of
registered listeners for each type
* Used the "get" methods in the abstract base classes to (a) avoid
problems if the list of listeners is modified while being traversed
to fire events, and (b) took the event firing calls out of the
synchronization blocks to avoid overhead when an event listener
might take a long time to return.
<snip/>
Nice. Thanks a lot for these vital improvements / fixes!
There is some noise about the implements Serializable clause here, and
SCXMLDialogContext has ended up being no longer Serializable. For
consistency across the two implementations (see fragments below), I'm
proposing (will commit in a minute, we can always change) to do the
following:
* Have the base classes implement Serializable where applicable
* Remove any redundant implements clauses on the concrete subclasses
-Rahul
<snap/>
*/
-public final class BasicDialogManager implements DialogContextManager,
Serializable {
+public final class BasicDialogManager extends AbstractDialogContextManager
+ implements DialogContextManager, Serializable {
<snip/>
*/
-public final class SCXMLDialogManager implements DialogContextManager,
Serializable {
+public final class SCXMLDialogManager
+ extends AbstractDialogContextManager implements Serializable {
<snap/>
