Yes. We could discuss step 2 at this email. And I think after we remove the old modules, errors will happen in callers. I could fix the errors by using new modules.
sunbufu <[email protected]> 于2019年12月12日周四 下午6:30写道： > I misunderstood the meaning of yuan in last email. But after communicating > with yuan on WeChat, we get a tentative agreement want to discuss with you . > We need 2 main steps to do in reconstruct orchestration module. > > > # 1 Replace old orchestration module with new orchestration module. > > > ## 1.1 Remove the old modules. > ## 1.2 Rename the new modules. > ## 1.3 Modify references we can easy find. > ## 1.4 Follow the error lead. > > > # 2 Replace old registry call relations with new config center, registry > center, distributed lock manager. > > > About step 2, we still have a lot to do, such as which data should be > manage by the new registry center. So we think we can discuss the step 2 in > other email. > > > > > ————————— > Haisheng Sun (sunbufu) > Apache ShardingSphere > > > On 12/12/2019 10:42，Juan Pan<[email protected]> wrote： > Take it easy. And FYI, maybe we could modify the internal of orchestration > without changing API of orchestration. When the refactoring of > orchestration finishes, API changes and behavior changes of callers comes. > > > Juan Pan > > > [email protected] > Juan Pan(Trista), Apache ShardingSphere > > > On 12/11/2019 20:32，sunbufu<[email protected]> wrote： > I think this maybe not so hard, we can do this like follow. > > > 1. Remove the old modules. > 2. Rename the new modules. > 3. Modify references we can easy find. > 4.Follow the error lead. > > > ————————— > Haisheng Sun (sunbufu) > Apache ShardingSphere > > > On 12/11/2019 16:14，guangyuan wang<[email protected]> wrote： > The modifications in sharding-orchestration are: > 1. The RegistryCenter is changed to split into 3 interfaces: ConfigCenter, > Registry Center, DistributedLockManagement. > 2. The related implementation class is changed and initialization is > changed. > These changes mean the sharding-orchestration module will be totally > changed. > So we create two modules in the sharding-orchestration to replace old > modules in the sharding-orchestration. > And now I wanna make the replacing. But it's huge task, because many > classes of the sharding-orchestration are called by other modules. > I'd like to discuss the workflow of the replacing, to make this action > safely be done without any unit test failure. > > Juan Pan <[email protected]> 于2019年12月11日周三 下午4:02写道： > > Hi Yuan, > > > I’d like to join in discussion, however i have no idea about what is going > now, could you draft a workflow or schedule to give us a basic > understanding about it. Based on that, maybe others could give some great > suggestion or idea. > > > Juan Pan > > > [email protected] > Juan Pan(Trista), Apache ShardingSphere > > > On 12/11/2019 14:28，guangyuan wang<[email protected]> wrote： > Hello everyone > I'd like to reconstruct the sharding-orchestration module. So far as, we > have develop a new sharding-orchestration-center module and > sharding-orchestration-core-new module. I'd like to use them to replace the > old ones. But It's really huge engineering. So I'd like to discuss the > workflow of the reconstruction. Do you have any good suggestions? > >
