+1, Hi Nianjun, I found that some dependent versions in the LICENSE have not been updated: - lib version: accessors-smart 2.4.9, license version: accessors-smart 2.4.7 - lib version: perfmark-api 0.26.0, license version: perfmark-api 0.25.0 - lib version: proj4j 1.2.2, license version: proj4j 1.1.5 - lib version: asm 9.3, license version: asm 9.1 - lib version: proto-google-common-protos 2.22.0, license version: proto-google-common-protos 2.9.0 - lib version: commons-compiler 3.1.9, license version: commons-compiler 3.1.8
But I think this will not affect the release, we only need to update the license in time after release. So I vote +1. Besides I checked following items. [x] Download links are valid. [x] Checksums and PGP signatures are valid. [x] Source code distributions have correct names matching the current release. [x] LICENSE and NOTICE files are correct for each ShardingSphere repo. [x] All files have license headers if necessary. [x] No compiled archives bundled in source archive. Best regards, Zhengqiang —————————————————————— Zhengqiang Duan (duanzhengqi...@apache.org) Apache ShardingSphere PMC GitHub@strongduanmu Nianjun Sun <sunnian...@apache.org> 于2023年10月18日周三 03:49写道： > Hello ShardingSphere Community, > > This is a call for vote to release Apache ShardingSphere version 5.4.1 > > Release notes: > > https://github.com/apache/shardingsphere/blob/5.4.1-release/RELEASE-NOTES.md > > The release candidates: > https://dist.apache.org/repos/dist/dev/shardingsphere/5.4.1/ > > Maven 2 staging repository: > > https://repository.apache.org/content/repositories/staging/org/apache/shardingsphere/ > > Git tag for the release: > https://github.com/apache/shardingsphere/tree/5.4.1/ > > Release Commit ID: > > https://github.com/apache/shardingsphere/commit/0ee4fb69031c7be40affc1c8ea3a5da93cb0a762 > > Keys to verify the Release Candidate: > https://dist.apache.org/repos/dist/dev/shardingsphere/KEYS > > Look at here for how to verify this release candidate: > > https://shardingsphere.apache.org/community/en/involved/release/shardingsphere/ > GPG user ID: > Nianjun Sun > > The vote will be open for at least 72 hours or until necessary number of > votes are reached. > Please vote accordingly: > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove with the reason > PMC vote is +1 binding, all others is +1 non-binding. > Checklist for reference: > [ ] Download links are valid. > [ ] Checksums and PGP signatures are valid. > [ ] Source code distributions have correct names matching the current > release. > [ ] LICENSE and NOTICE files are correct for each ShardingSphere repo. > [ ] All files have license headers if necessary. > [ ] No compiled archives bundled in source archive. >
