+1 I checked with building from sources and quarkus-shardingsphere-jdbc [1]. But the only concern is that there are a lot of SPI package renames and moves, since this is only a micro upgrade from 5.4.0 to 5.4.1, these changes could not be expected from 3rd party users.
So maybe we can consider doing the minor version change at least in the future. Anyway, thanks for all the contributions! Regards, Zheng Feng [1] https://github.com/quarkiverse/quarkus-shardingsphere-jdbc guangyuan wang <wangguangy...@apache.org> 于2023年10月19日周四 22:08写道： > +1 > I've checked below items: > [X] Download links are valid. > [X] Checksums and PGP signatures are valid. > [X] Source code distributions have correct names matching the current > release. > [X] LICENSE and NOTICE files are correct for each ShardingSphere repo. > [X] All files have license headers if necessary. > [X] No compiled archives bundled in source archive. > > zhangli...@apache.org <zhangli...@apache.org> 于2023年10月19日周四 00:04写道： > > > +1 > > > > I checked: > > [X] Download links are valid. > > [X] Checksums and PGP signatures are valid. > > [X] Source code distributions have correct names matching the current > > release. > > [X] LICENSE and NOTICE files are correct for each ShardingSphere repo. > > [X] All files have license headers if necessary. > > [X] No compiled archives bundled in source archive. > > > > ------------------ > > > > Sincerely, > > Liang Zhang (John) > > Apache ShardingSphere > > > > > > Hongsheng Zhong <zhonghongsh...@apache.org> 于2023年10月18日周三 21:16写道： > > > > > +1 > > > > > > I've checked: > > > [ x ] Download links are valid. > > > [ x ] Checksums and PGP signatures are valid. > > > [ x ] Source code distributions have correct names matching the current > > > release. > > > [ x ] LICENSE and NOTICE files are correct for each ShardingSphere > repo. > > > [ x ] All files have license headers if necessary. > > > [ x ] No compiled archives bundled in source archive. > > > [ x ] Codes can be compiled and pass the unit tests. > > > > > > > > > On 2023/10/17 19:48:52 Nianjun Sun wrote: > > > > Hello ShardingSphere Community, > > > > > > > > This is a call for vote to release Apache ShardingSphere version > 5.4.1 > > > > > > > > Release notes: > > > > > > > > > > https://github.com/apache/shardingsphere/blob/5.4.1-release/RELEASE-NOTES.md > > > > > > > > The release candidates: > > > > https://dist.apache.org/repos/dist/dev/shardingsphere/5.4.1/ > > > > > > > > Maven 2 staging repository: > > > > > > > > > > https://repository.apache.org/content/repositories/staging/org/apache/shardingsphere/ > > > > > > > > Git tag for the release: > > > > https://github.com/apache/shardingsphere/tree/5.4.1/ > > > > > > > > Release Commit ID: > > > > > > > > > > https://github.com/apache/shardingsphere/commit/0ee4fb69031c7be40affc1c8ea3a5da93cb0a762 > > > > > > > > Keys to verify the Release Candidate: > > > > https://dist.apache.org/repos/dist/dev/shardingsphere/KEYS > > > > > > > > Look at here for how to verify this release candidate: > > > > > > > > > > https://shardingsphere.apache.org/community/en/involved/release/shardingsphere/ > > > > GPG user ID: > > > > Nianjun Sun > > > > > > > > The vote will be open for at least 72 hours or until necessary number > > of > > > > votes are reached. > > > > Please vote accordingly: > > > > [ ] +1 approve > > > > [ ] +0 no opinion > > > > [ ] -1 disapprove with the reason > > > > PMC vote is +1 binding, all others is +1 non-binding. > > > > Checklist for reference: > > > > [ ] Download links are valid. > > > > [ ] Checksums and PGP signatures are valid. > > > > [ ] Source code distributions have correct names matching the current > > > > release. > > > > [ ] LICENSE and NOTICE files are correct for each ShardingSphere > repo. > > > > [ ] All files have license headers if necessary. > > > > [ ] No compiled archives bundled in source archive. > > > > > > > > > >
