http://codereview.appspot.com/969041/diff/1/3
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HtmlAccelServlet.java
(right):

http://codereview.appspot.com/969041/diff/1/3#newcode237
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HtmlAccelServlet.java:237:
String path = req.getRequestURI();
slight preference to use the UriBuilder(HttpServletRequest) mechanism to
build a Uri, then pull it apart. Avoids split logic dealing w/ HSR <->
URI parsing.

http://codereview.appspot.com/969041/diff/1/3#newcode241
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HtmlAccelServlet.java:241:
if (path.startsWith(accelServletPrefix + "/")) {
it's been a while since I've used this, so I'd defer to others with more
recent experience as to the reliability of this method -- but it seems:
http://java.sun.com/products/servlet/2.2/javadoc/javax/servlet/http/HttpServletRequest.html#getServletPath()

..may provide accelServletPrefix without any additional configuration.

http://codereview.appspot.com/969041/diff/1/3#newcode250
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HtmlAccelServlet.java:250:
if (accelUrl == null){
s/null check/!StringUtils.isEmptyOrWhitespace(...)/

http://codereview.appspot.com/969041/show

Reply via email to