The change remove the support for refresh and container intentionally. I don't think it add much value at this point. The getAccelRequest suppose to also return the parameters at one point. So I think instead of renaming I will just implement it correctly with paramater parsing. It will be called getAccelParams, which return map of parameters. It will parse chain or parametrized style, fill in the url, and some defaults such as a container.
Attachment later today. On Fri, Apr 23, 2010 at 1:11 AM, <[email protected]> wrote: > one more nit while I'm at it. > > > > http://codereview.appspot.com/969041/diff/11001/12002 > File > > java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HtmlAccelServlet.java > (right): > > http://codereview.appspot.com/969041/diff/11001/12002#newcode229 > > java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HtmlAccelServlet.java:229: > private Uri getAccelRequest(HttpServletRequest req) throws > GadgetException { > nit: suggest renaming to getAccelUri, and make protected since it will > likely prove a useful helper method for subclassers. > > > http://codereview.appspot.com/969041/show >
