Re: Support chain style paramaters fror accel servlet (issue969041)

[zhoresh]

All done and submitted!

On 2010/04/29 22:23:17, johnfargo wrote:

Final nits and minor suggestions. LGTM in general; fix what you wish

and submit

(first CL submitted I believe!)

http://codereview.appspot.com/969041/diff/16002/18002
File

java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HtmlAccelServlet.java

(right):

http://codereview.appspot.com/969041/diff/16002/18002#newcode112

java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HtmlAccelServlet.java:112:

// Create request to hanlde parsed params
nit: s/hanlde/handle/

http://codereview.appspot.com/969041/diff/16002/18002#newcode117

java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HtmlAccelServlet.java:117:

return requestParams.get(name).get(0);
nit: this does a double-lookup. I'd just do:
List<String> values = reqParams.get(name);
if (values != null && values.size() > 0) return values.get(0);

http://codereview.appspot.com/969041/diff/16002/18002#newcode170

java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HtmlAccelServlet.java:170:

return requestParams.get(name).get(0);
could just use dataWrapper.getParameter(name)

http://codereview.appspot.com/969041/show