Reviewers: shindig.remailer_gmail.com, johnfargo,
Description:
Fix handling of refresh time by ProxyHandler.
The handler class already handle the refresh so skip the refresh update
in the proxy base.
The real problem was that chain param style proxy refresh would be
ignored and replaced with the default.
Please review this at http://codereview.appspot.com/1215041/show
Affected files:
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyBase.java
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java
### Eclipse Workspace Patch 1.0
#P shindig-project
Index:
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyBase.java
===================================================================
---
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyBase.java
(revision 936555)
+++
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyBase.java
(working copy)
@@ -129,6 +129,11 @@
refreshInterval = Math.max(60 * 60, (int)(results.getCacheTtl() /
1000L));
}
HttpUtil.setCachingHeaders(response, refreshInterval);
+ setResponseContentHeaders(response, results);
+
+ }
+
+ protected void setResponseContentHeaders(HttpServletResponse response,
HttpResponse results) {
// We're skipping the content disposition header for flash due to an
issue with Flash player 10
// This does make some sites a higher value phishing target, but this
can be mitigated by
Index:
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java
===================================================================
---
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java
(revision 936555)
+++
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java
(working copy)
@@ -161,7 +161,7 @@
}
}
- setResponseHeaders(request, response, results);
+ setResponseContentHeaders(response, results);
if (results.getHttpStatusCode() != HttpResponse.SC_OK) {
if (results.getHttpStatusCode() ==
HttpResponse.SC_INTERNAL_SERVER_ERROR) {
