On Tue, Jun 1, 2010 at 11:17 PM, <[email protected]> wrote:
>
> http://codereview.appspot.com/1304042/diff/1/30
> File
>
>
> java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/RewriteModule.java
> (right):
>
> http://codereview.appspot.com/1304042/diff/1/30#newcode74
>
> java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/RewriteModule.java:74:
> // TODO: Clean this up.
> details?
>
Thinking about this more, I've slightly modified it (still not fully
satisfied though) to the following. As described in the updated TODO
comment, it just seems a little funny that I'm creating the registry via
"new" here. Perhaps I'm just missing the appriate Guice-fu.
// TODO: Clean this up. Ideally we would let the ResponseRewriterRegistry
// binding create the concrete object instance.
@Provides
@Singleton
@Named("shindig.rewriters.response.pre-cache")
protected ResponseRewriterRegistry
providePreCacheResponseRewritersRegistry(
GadgetHtmlParser parser,
@Named("shindig.rewriters.response.pre-cache") List<ResponseRewriter>
preCached) {
return new DefaultResponseRewriterRegistry(preCached, parser);
}
@Provides
@Singleton
@Named("shindig.rewriters.response.pre-cache")
protected List<ResponseRewriter> providePreCacheResponseRewriters(
BasicImageRewriter imageRewriter) {
return ImmutableList.<ResponseRewriter>of(imageRewriter);
}
> also change signature to providePreCacheResponseRewriters to not clash
> with method below..
>
Done.
>
> http://codereview.appspot.com/1304042/diff/1/30#newcode88
>
> java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/RewriteModule.java:88:
> protected List<ResponseRewriter> provideRequestRewriters(
> rename to provideResponseRewriters
Done.
>
>
> http://codereview.appspot.com/1304042/show
>
