Just committed a CL renaming all XRequestRewriter to XResponseRewriter. Thx- John
On Wed, Jun 2, 2010 at 12:14 AM, <[email protected]> wrote: > lgtm > > > http://codereview.appspot.com/1304042/diff/1/21 > File > > java/gadgets/src/main/java/org/apache/shindig/gadgets/render/SanitizingRequestRewriter.java > (right): > > http://codereview.appspot.com/1304042/diff/1/21#newcode42 > > java/gadgets/src/main/java/org/apache/shindig/gadgets/render/SanitizingRequestRewriter.java:42: > public class SanitizingRequestRewriter implements ResponseRewriter { > What do you think about renaming the class name to > SanitizingResponseRewriter. We can make this change after the branch is > cut. > > s/SanitizingRequestRewriter/SanitizingResponseRewriter > > http://codereview.appspot.com/1304042/diff/1/21#newcode115 > > java/gadgets/src/main/java/org/apache/shindig/gadgets/render/SanitizingRequestRewriter.java:115: > resp.setContent(""); > I'd log a debug message here > > http://codereview.appspot.com/1304042/diff/1/4 > File > > java/gadgets/src/test/java/org/apache/shindig/gadgets/render/SanitizingRequestRewriterTest.java > (right): > > http://codereview.appspot.com/1304042/diff/1/4#newcode40 > > java/gadgets/src/test/java/org/apache/shindig/gadgets/render/SanitizingRequestRewriterTest.java:40: > public class SanitizingRequestRewriterTest extends RewriterTestBase { > s/SanitizingRequestRewriterTest/SanitizingResponseRewriterTest > > > http://codereview.appspot.com/1304042/show >
