seems fine on the surface. However I applied this patch and commented
out the tests in CajaSocialMarkupHtmlParserTest -- instead of throwing
NPEs they fail with assertions like this:
java.lang.AssertionError: expected:<1> but was:<0>
at org.junit.Assert.fail(Assert.java:91)
at org.junit.Assert.failNotEquals(Assert.java:645)
at org.junit.Assert.assertEquals(Assert.java:126)
at org.junit.Assert.assertEquals(Assert.java:470)
at org.junit.Assert.assertEquals(Assert.java:454)
at
org.apache.shindig.gadgets.parse.AbstractSocialMarkupHtmlParserTest.testSocialData(AbstractSocialMarkupHtmlParserTest.java:62)
at
org.apache.shindig.gadgets.parse.caja.CajaSocialMarkupHtmlParserTest.testSocialData(CajaSocialMarkupHtmlParserTest.java:37)
I'd love to see these tests working again...
Thanks!
http://codereview.appspot.com/1460041/show
