I'm not sure why Paul got broken tests w/ this patch -- my equivalent
(http://codereview.appspot.com/1714043/show) sees them working nicely.


http://codereview.appspot.com/1460041/diff/9001/10002
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java
(right):

http://codereview.appspot.com/1460041/diff/9001/10002#newcode176
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java:176:
response.getContentType(), response.getEncoding());
minor preference for getContentType being a helper method here rather
than in HttpResponse to prevent latter from getting too big

http://codereview.appspot.com/1460041/diff/9001/10002#newcode186
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java:186:
return UriPolicy.IDENTITY;
FMI what's this do? Just returns same? Why remove the previous logic?

http://codereview.appspot.com/1460041/show

Reply via email to