Ah, missed the non-diffed lines. Lgtm. Will commit if nobody else has by the time I get to a workstation again.
Cheers John On 2010/06/24 01:16:46, janluehe wrote:
http://codereview.appspot.com/1712045/diff/1/2 File
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponseBuilder.java
(right):
http://codereview.appspot.com/1712045/diff/1/2#newcode117
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponseBuilder.java:117:
values.add(newContentType); On 2010/06/24 01:03:46, johnfargo wrote: > FMI how is this impl any different?
In the original code, "newContentType" is of type StringBuilder, and
is being
passed to the equals method of "contentType", which is of type String,
prompting
findbugs to log this warning:
Call to equals() comparing different types in
org.apache.shindig.gadgets.http.HttpResponseBuilder.setEncoding(Charset)
In the new code, "newContentType" is of type String.
http://codereview.appspot.com/1712045/show
