Looks like Paul got to it before I did -- happy to look at patch set 2 when it comes about.
Cheers, John On 2010/06/24 17:59:19, janluehe wrote:
Thanks for committing, John!
I'm about to create Patch Set 2, which contains fixes for the
following Findbugs
issues (I've also taken the liberty to fix all equals methods that
were missing
a check for reference identity):
- Unread field:
org.apache.shindig.gadgets.oauth.testing.FakeOAuthServiceProvider$TokenState.consumer
- Suspicious comparison of a Integer reference to constant in
org.apache.shindig.gadgets.rewrite.old.ProxyingLinkRewriter.rewrite(String, Uri)
- org.apache.shindig.gadgets.uri.ProxyUriManager$ProxyUri defines
equals but not
hashCode
- Exception is caught when Exception is not thrown in new
org.apache.shindig.gadgets.parse.ParseModule$DOMImplementationProvider()
- Invocation of hashCode on array in org.apache.shindig.gadgets.http.HttpRequest.hashCode() -> The code invokes hashCode on an array. Calling hashCode on an
array returns
the same value as System.identityHashCode, and igores the contents and
length of
the array. If you need a hashCode that depends on the contents of an
array a,
use java.util.Arrays.hashCode(a).
- Invocation of hashCode on array in org.apache.shindig.gadgets.http.HttpRequest.hashCode() -> See above for recommended fix
http://codereview.appspot.com/1712045/show
