LGTM
On 2010/07/20 06:30:08, jasvir wrote:
http://codereview.appspot.com/1852041/diff/1/4
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaCssParser.java
(right):
http://codereview.appspot.com/1852041/diff/1/4#newcode56
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaCssParser.java:56:
* TODO(jasvir): This ought to be set to the real URI for accurate
reporting
On 2010/07/16 01:12:34, johnfargo wrote:
> want to just do it in this CL? all calling contexts have the source
Uri
> available.
I also changed the relative urls like "www.example.org/foo" into
actual absolute
ones.
Done.
http://codereview.appspot.com/1852041/diff/1/5
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriter.java
(right):
http://codereview.appspot.com/1852041/diff/1/5#newcode167
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriter.java:167:
// Extract the import statment, add its URI to the returned list
On 2010/07/16 01:12:34, johnfargo wrote:
> nit: statement
Done.
http://codereview.appspot.com/1852041/diff/1/5#newcode171
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriter.java:171:
((AbstractParseTreeNode)
chain.getParentNode()).removeChild(chain.node);
On 2010/07/16 01:12:34, johnfargo wrote:
> Specifically, rewriting the Uri of the @import, when !extractImports
AFAICT.
>
> On 2010/07/15 19:17:32, gagan.goku wrote:
> > The block corresponding to
> > if (extractImports) {
> > ...} else {
> > dont remove @import url node.
> > }
> >
> > is missing.
>
>
Done.
http://codereview.appspot.com/1852041/diff/1/5#newcode171
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriter.java:171:
((AbstractParseTreeNode)
chain.getParentNode()).removeChild(chain.node);
On 2010/07/15 19:17:32, gagan.goku wrote:
> The block corresponding to
> if (extractImports) {
> ...} else {
> dont remove @import url node.
> }
>
> is missing.
Done.
http://codereview.appspot.com/1852041/diff/1/2
File
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriterTest.java
(right):
http://codereview.appspot.com/1852041/diff/1/2#newcode28
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriterTest.java:28:
import org.apache.shindig.gadgets.parse.caja.CajaCssParser;
On 2010/07/15 19:17:32, gagan.goku wrote:
> Please add @import "http://www.example.org"; test case.
Done.
http://codereview.appspot.com/1852041/show
