I'm sorry, I made a mistake. Have a nice day for all. -----Original Message----- From: VU, Thi Thu Thuy [mailto:[email protected]] Sent: lundi 26 juillet 2010 15:29 To: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected] Subject: RE: Returning same status code as fetched (issue1811042)
0612452548 -----Original Message----- From: [email protected] [mailto:[email protected]] Sent: lundi 26 juillet 2010 14:16 To: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected] Cc: [email protected] Subject: Re: Returning same status code as fetched (issue1811042) LGTM. http://codereview.appspot.com/1811042/diff/37001/38001 File common/conf/shindig.properties (right): http://codereview.appspot.com/1811042/diff/37001/38001#newcode145 common/conf/shindig.properties:145: # Remap internal server errors received from the server being proxied to Rephrase as: Remap "Internal server error"s received from the basicHttpFetcherProxy server to "Bad Gateway error"s, so that it is clear to the user that the proxy server is the one that threw the exception. http://codereview.appspot.com/1811042/diff/37001/38002 File gadgets/src/main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java (right): http://codereview.appspot.com/1811042/diff/37001/38002#newcode107 gadgets/src/main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java:107: sendResponse(req, results, response); Since we don't have multiple calls to sendResponse, you can remove the method and just add back the code here as before. http://codereview.appspot.com/1811042/show
