http://codereview.appspot.com/1811042/diff/23001/24002
File main/java/org/apache/shindig/gadgets/uri/UriUtils.java (left):

http://codereview.appspot.com/1811042/diff/23001/24002#oldcode129
main/java/org/apache/shindig/gadgets/uri/UriUtils.java:129:
resp.sendError(HttpResponse.SC_BAD_GATEWAY);
this remapping is critical for many ppl's production monitoring. if you
want to send 500s for accel straight through that's fine but the change
should be limited to accel only.

http://codereview.appspot.com/1811042/diff/23001/24003
File
test/java/org/apache/shindig/gadgets/servlet/HtmlAccelServletTest.java
(right):

http://codereview.appspot.com/1811042/diff/23001/24003#newcode197
test/java/org/apache/shindig/gadgets/servlet/HtmlAccelServletTest.java:197:
assertEquals(5001, recorder.getHttpStatusCode());
you should keep the test w/ status 500

http://codereview.appspot.com/1811042/show

Reply via email to