http://codereview.appspot.com/1855044/diff/45001/46004
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyBase.java
(left):

http://codereview.appspot.com/1855044/diff/45001/46004#oldcode60
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyBase.java:60:
"vary", "expires", "date", "pragma", "cache-control",
"transfer-encoding", "www-authenticate"
Please make sure you don't loose this values as part of the change.

http://codereview.appspot.com/1855044/diff/45001/46005
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java
(right):

http://codereview.appspot.com/1855044/diff/45001/46005#newcode154
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java:154:
IOUtils.copy(results.getResponse(), response.getOutputStream());
You probably don't want to copy data in case of error.

http://codereview.appspot.com/1855044/show

Reply via email to