LGTM, committed as r981703.
On 2010/07/29 18:03:22, anupama.dutta wrote:
http://codereview.appspot.com/1855044/diff/67001/63010
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/UriUtils.java
(right):
http://codereview.appspot.com/1855044/diff/67001/63010#newcode79
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/UriUtils.java:79:
*
NOTE: RFC 822 section 3.1.2 describes the structure of header fields.
On 2010/07/29 17:49:09, gagan.goku wrote:
> Would be awesome if you could a 1 line english description of what
values are
> allowed, like "all printable ascii characters other than : are
allowed".
Done.
http://codereview.appspot.com/1855044/diff/67001/63010#newcode101
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/UriUtils.java:101:
*
@param val The header value.
On 2010/07/29 17:49:09, gagan.goku wrote:
> Would be awesome if you could a 1 line english description of what
values are
> allowed, like "all ascii characters other than CR and LF are
allowed".
Done.
http://codereview.appspot.com/1855044/diff/67001/63010#newcode158
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/UriUtils.java:158:
LOG.info("Skipping illegal header: " + entry.getKey() + ":" +
entry.getValue());
On 2010/07/29 17:49:09, gagan.goku wrote:
> LOG.warning ?
Done.
http://codereview.appspot.com/1855044/show
