One could create a content jar. however I'd like to see container specific javascript migrated to the features directory. We already did that for the old shindig container, the other bits would make sense to move there as well.
On Thu, Sep 9, 2010 at 12:31 PM, Gagandeep singh <[email protected]>wrote: > Hi Paul > > After some investigation, it seems we do use more files. It seems > cookiebaseduserprefstore.js is > served out as well, along with some other files like gadgets.js etc. > Seeing that these are getting used, it is okay to add another jar file, say > shindig-content.jar (see 2142045 <http://codereview.appspot.com/2142045/>for > dummy codereview). > > I don't know much about the overheads of adding a new jar etc. so your > comments / suggestions are greatly appreciated. > > Thanks > Gagan > > On Tue, Sep 7, 2010 at 12:31 PM, Paul Lindner <[email protected]> wrote: > >> I added that one file back to the the shindig-gadget jar. Let us know if >> that helps. >> >> >> On Sat, Sep 4, 2010 at 9:49 AM, Gagandeep singh <[email protected]>wrote: >> >>> We have a test that fails because its not able to find >>> container/rpc_relay.html. Not sure if any other files are being actively >>> used as well. >>> >>> >>> On Sat, Sep 4, 2010 at 9:11 PM, Gagandeep singh <[email protected]>wrote: >>> >>>> Sorry for the short and confusing mail. I am not sure whether static >>>> files should be included in gadgets.jar or not. I was trying to incorporate >>>> shindig head into our system and noticed a failure most likely caused by >>>> the >>>> removal of static files. >>>> >>>> If this is not the right change to make, please do not mind this change >>>> and indicate what i should be doing instead. Any information would be >>>> greatly appreciated. >>>> >>>> Thanks >>>> Gagan >>>> >>>> >>>> On Sat, Sep 4, 2010 at 8:33 PM, Gagandeep singh >>>> <[email protected]>wrote: >>>> >>>>> Reviewers: [email protected], lindner, zhoresh >>>>> >>>>> Description: >>>>> >>>>> Adding back static files removed in revision 991493. >>>>> See >>>>> here:http://svn.apache.org/viewvc/shindig/trunk/java/gadgets/pom.xml?r1=991493&r2=... >>>>> >>>>> <http://svn.apache.org/viewvc/shindig/trunk/java/gadgets/pom.xml?r1=991493&r2=991492&pathrev=991493> >>>>> >>>>> I think this started with >>>>> https://issues.apache.org/jira/browse/SHINDIG-1370 >>>>> whereby we removed the static files from shindig server.jar >>>>> >>>>> >>>>> Please review this at http://codereview.appspot.com/2136044/ >>>>> >>>>> Affected files: >>>>> M java/gadgets/pom.xml >>>>> >>>>> >>>>> Thanks >>>>> Gagan >>>>> >>>>> >>>> >>> >> >> >> -- >> Paul Lindner -- [email protected] -- linkedin.com/in/plindner >> > > -- Paul Lindner -- [email protected] -- linkedin.com/in/plindner
