Hi Paul I don't have much idea about the container / gadget related javascript and html files. Could you point me to some documentation / commits that can help me get more idea.
Did you mean something like: 1) remove the files content/container/cookiebaseduserprefstore.js and other similar files which have are also present in features/src/main/javascript/features/shindig.container/ directory and migrate the usages. 2) move files like content/container/... to features directory. Sorry if i've totally got it wrong. I tried reading up about gadgets and stuff but got confused. I guess a pointer in the right direction would be very helpful. Thanks Gagan On Fri, Sep 10, 2010 at 2:15 AM, Paul Lindner <[email protected]> wrote: > One could create a content jar. > > however I'd like to see container specific javascript migrated to the > features directory. We already did that for the old shindig container, the > other bits would make sense to move there as well. > > > On Thu, Sep 9, 2010 at 12:31 PM, Gagandeep singh <[email protected]>wrote: > >> Hi Paul >> >> After some investigation, it seems we do use more files. It seems >> cookiebaseduserprefstore.js is >> served out as well, along with some other files like gadgets.js etc. >> Seeing that these are getting used, it is okay to add another jar file, >> say shindig-content.jar (see >> 2142045<http://codereview.appspot.com/2142045/>for dummy codereview). >> >> I don't know much about the overheads of adding a new jar etc. so your >> comments / suggestions are greatly appreciated. >> >> Thanks >> Gagan >> >> On Tue, Sep 7, 2010 at 12:31 PM, Paul Lindner <[email protected]> wrote: >> >>> I added that one file back to the the shindig-gadget jar. Let us know if >>> that helps. >>> >>> >>> On Sat, Sep 4, 2010 at 9:49 AM, Gagandeep singh <[email protected]>wrote: >>> >>>> We have a test that fails because its not able to find >>>> container/rpc_relay.html. Not sure if any other files are being actively >>>> used as well. >>>> >>>> >>>> On Sat, Sep 4, 2010 at 9:11 PM, Gagandeep singh >>>> <[email protected]>wrote: >>>> >>>>> Sorry for the short and confusing mail. I am not sure whether static >>>>> files should be included in gadgets.jar or not. I was trying to >>>>> incorporate >>>>> shindig head into our system and noticed a failure most likely caused by >>>>> the >>>>> removal of static files. >>>>> >>>>> If this is not the right change to make, please do not mind this change >>>>> and indicate what i should be doing instead. Any information would be >>>>> greatly appreciated. >>>>> >>>>> Thanks >>>>> Gagan >>>>> >>>>> >>>>> On Sat, Sep 4, 2010 at 8:33 PM, Gagandeep singh >>>>> <[email protected]>wrote: >>>>> >>>>>> Reviewers: [email protected], lindner, zhoresh >>>>>> >>>>>> Description: >>>>>> >>>>>> Adding back static files removed in revision 991493. >>>>>> See >>>>>> here:http://svn.apache.org/viewvc/shindig/trunk/java/gadgets/pom.xml?r1=991493&r2=... >>>>>> >>>>>> <http://svn.apache.org/viewvc/shindig/trunk/java/gadgets/pom.xml?r1=991493&r2=991492&pathrev=991493> >>>>>> >>>>>> I think this started with >>>>>> https://issues.apache.org/jira/browse/SHINDIG-1370 >>>>>> whereby we removed the static files from shindig server.jar >>>>>> >>>>>> >>>>>> Please review this at http://codereview.appspot.com/2136044/ >>>>>> >>>>>> Affected files: >>>>>> M java/gadgets/pom.xml >>>>>> >>>>>> >>>>>> Thanks >>>>>> Gagan >>>>>> >>>>>> >>>>> >>>> >>> >>> >>> -- >>> Paul Lindner -- [email protected] -- linkedin.com/in/plindner >>> >> >> > > > -- > Paul Lindner -- [email protected] -- linkedin.com/in/plindner >
