Re: Concatenated URLs should not exceed GET URL size limit (issue3734041)

[pulkitgoyal2000]

http://codereview.appspot.com/3734041/diff/108001/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManager.java
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManager.java
(right):

http://codereview.appspot.com/3734041/diff/108001/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManager.java#newcode132
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManager.java:132:
uriBuilders.add(uriBuilder);
On 2011/02/01 13:40:30, anupama.dutta wrote:

Most of the code here (from line 132 - 139) are repititions from the

block

before the for loop. Could we remove the code from outside the for

loop and

bring the first iteration in here itself?

Done.

http://codereview.appspot.com/3734041/diff/117001/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/ConcatUriManager.java
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/ConcatUriManager.java
(right):

http://codereview.appspot.com/3734041/diff/117001/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/ConcatUriManager.java#newcode119
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/ConcatUriManager.java:119:
this.uris = uris;
On 2011/02/01 23:58:55, johnfargo wrote:

nit: Collections.unmodifiableList(uris)

Done.

http://codereview.appspot.com/3734041/